This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH -v3] watchdog, SP5100: Check if firmware has set

To: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH -v3] watchdog, SP5100: Check if firmware has set correct value in tcobase.
From: Yinghai Lu <yinghai@xxxxxxxxxx>
Date: Fri, 18 Mar 2011 09:39:06 -0700
Cc: Priyanka Gupta <priyankag@xxxxxxxxxx>, Jeremy Fitzhardinge <jeremy@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, linux-watchdog@xxxxxxxxxxxxxxx, Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, Mike Waychison <mikew@xxxxxxxxxx>, Wim Van Sebroeck <wim@xxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>
Delivery-date: Fri, 18 Mar 2011 09:39:45 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=ZR3gQ9gvHoJf/wn2a/pJS1Cs+CHds1KDbpYKmu+ZBNM=; b=EmAIuNG6M338to1FK4xUyFE+39x5Y548X695S9azjx/nfSKrSi2KXtZVKOdhfhMabQ 90WP1VLRXl3h38jgQkNtvKp9eY2bYni257yt/IuU1kGdiUUf1leiutQo9AWpoCW8EcGy p81MHEfAC/DUJk4bcpFeq5FbYrMjzoBdW7Xo8=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=ffuJToml7A5V05qkb0od+mdTkSuiaZMur0ZsPCtam3fF0yUHbGcr9MldO2Q3o9v/9f TRQBUO3ANqcQ1fLeZ0ar6btWSPKb2VS7b+4p4u91prw+TKLvvTDyPYbRouGiCN4ODZ1U qLNN5XeKqBhIjHt2EaSx5NkFa9zX6xHkXLx8Q=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20110318131025.GA3786@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20110311222129.GA3168@xxxxxxxxxxxx> <alpine.DEB.2.00.1103161150010.3382@kaball-desktop> <alpine.DEB.2.00.1103161442210.3382@kaball-desktop> <4D80F992.10603@xxxxxxxxxx> <alpine.DEB.2.00.1103161757040.3382@kaball-desktop> <4D812180.5030102@xxxxxxxxxx> <AANLkTimNva3c_-kGA+JLCPZgrKAbwqLKaN559cwTh7cq@xxxxxxxxxxxxxx> <4D812919.30706@xxxxxxxxxx> <20110317022331.GA3528@xxxxxxxxxxxx> <4D817973.7000407@xxxxxxxxxx> <20110318131025.GA3786@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Fri, Mar 18, 2011 at 6:10 AM, Konrad Rzeszutek Wilk
<konrad.wilk@xxxxxxxxxx> wrote:
> On Wed, Mar 16, 2011 at 08:01:07PM -0700, Yinghai Lu wrote:
>> Stefano found SP5100 TCO watchdog driver using wrong address.
>> [    9.148536] SP5100 TCO timer: SP5100 TCO WatchDog Timer Driver v0.01
>> [    9.148628] DEBUG __ioremap_caller WARNING address=b8fe00 size=8 valid=1 
>> reserved=1
>> and e820 said that range is RAM.
>> We should check if we can use that reading out. BIOS could just program 
>> wrong address there.
>> -v2: Mike pointed out one path need one release.
>> -v3: corrected logic checking with request_mem_region_exclusive()
>>      Found by Konrad.
> Yinghai:
> Not sure what you are using as a base, but I had to modify this patch
> to go on top of 2.6.38. Here is the patch that applies cleanly:


commit 4562f53940432369df88e195ef8f9b642bdf7cd6
Author: Wim Van Sebroeck <wim@xxxxxxxxx>
Date:   Mon Feb 21 12:16:44 2011 +0000

    watchdog: convert to DEFINE_PCI_DEVICE_TABLE

    Convert static struct pci_device_id *[] to static

    Signed-off-by: Wim Van Sebroeck <wim@xxxxxxxxx>

diff --git a/drivers/watchdog/sp5100_tco.c b/drivers/watchdog/sp5100_tco.c
index 8083728..1bc4938 100644
--- a/drivers/watchdog/sp5100_tco.c
+++ b/drivers/watchdog/sp5100_tco.c
@@ -259,7 +259,7 @@ static struct miscdevice sp5100_tco_miscdev = {
  * register a pci_driver, because someone else might
  * want to register another driver on the same PCI id.
-static struct pci_device_id sp5100_tco_pci_tbl[] = {
+static DEFINE_PCI_DEVICE_TABLE(sp5100_tco_pci_tbl) = {
          PCI_ANY_ID, },
        { 0, },                 /* End of list */

commit 15e28bf130081a574192fb934b832ac7d07739f7
Author: Priyanka Gupta <priyankag@xxxxxxxxxx>
Date:   Mon Oct 25 17:58:04 2010 -0700

    watchdog: Add support for sp5100 chipset TCO

    This driver adds /dev/watchdog support for the AMD sp5100 aka
SB7x0 chipsets.

    It follows the same conventions found in other /dev/watchdog drivers.

    Signed-off-by: Priyanka Gupta <priyankag@xxxxxxxxxx>
    Signed-off-by: Mike Waychison <mikew@xxxxxxxxxx>
    Signed-off-by: Wim Van Sebroeck <wim@xxxxxxxxx>

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>