This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [PATCH] watchdog, SP5100: Check if firmware has set corr

To: Yinghai Lu <yinghai@xxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH] watchdog, SP5100: Check if firmware has set correct value in tcobase.
From: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Date: Wed, 16 Mar 2011 22:23:31 -0400
Cc: Priyanka Gupta <priyankag@xxxxxxxxxx>, Jeremy Fitzhardinge <jeremy@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, linux-watchdog@xxxxxxxxxxxxxxx, Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, Mike Waychison <mikew@xxxxxxxxxx>, Wim Van Sebroeck <wim@xxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>
Delivery-date: Wed, 16 Mar 2011 19:25:13 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4D812919.30706@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <alpine.DEB.2.00.1103111201470.2968@kaball-desktop> <20110311222129.GA3168@xxxxxxxxxxxx> <alpine.DEB.2.00.1103161150010.3382@kaball-desktop> <alpine.DEB.2.00.1103161442210.3382@kaball-desktop> <4D80F992.10603@xxxxxxxxxx> <alpine.DEB.2.00.1103161757040.3382@kaball-desktop> <4D812180.5030102@xxxxxxxxxx> <AANLkTimNva3c_-kGA+JLCPZgrKAbwqLKaN559cwTh7cq@xxxxxxxxxxxxxx> <4D812919.30706@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.20 (2009-06-14)
On Wed, Mar 16, 2011 at 02:18:17PM -0700, Yinghai Lu wrote:
> Stefano found SP5100 TCO watchdog driver using wrong address.
> [    9.148536] SP5100 TCO timer: SP5100 TCO WatchDog Timer Driver v0.01
> [    9.148628] DEBUG __ioremap_caller WARNING address=b8fe00 size=8 valid=1 
> reserved=1
> and e820 said that range is RAM.
> We should check if we can use that reading out. BIOS could just program wrong 
> address there.
> -v2: Mike pointed out one path need one release.
> Reported-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> Signed-off-by:Yinghai Lu <yinghai@xxxxxxxxxx>
> Acked-by: Mike Waychison <mikew@xxxxxxxxxx>

I have no idea why it worked the first time b/c this:

> +     if (request_mem_region_exclusive(val, SP5100_WDT_MEM_MAP_SIZE, "SP5100 
> TCO")) {

is wrong. It should have been "if (!request...")..

With that, and with Stefano's patches (stefano/2.6.38-rc6-mm-fix) on top of 
2.6.39-rc0 it boots up fine.

Excerpt from the log:

[    0.000000] DEBUG find_early_table_space: _text=1000000 _end=1e33000 
pgtable_start=9fc000 pgtable_end=9fc000
[    0.000000] DEBUG find_early_table_space: _text=1000000 _end=1e33000 
pgtable_start=beba5000 pgtable_end=beba5000
[    9.064064] calling  sp5100_tco_init_module+0x0/0x1000 [sp5100_tco] @ 507
[    9.064067] SP5100 TCO timer: SP5100 TCO WatchDog Timer Driver v0.01
[    9.064180] SP5100 TCO timer: mmio address 0xb8fe00 already in use
[    9.064201] initcall sp5100_tco_init_module+0x0/0x1000 [sp5100_tco] returned 
0 after 126 usecs

Attached is the full log if folks are curious.

Attachment: d
Description: Text document

Xen-devel mailing list
<Prev in Thread] Current Thread [Next in Thread>