This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [PATCH] watchdog, SP5100: Check if firmware has set corr

To: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH] watchdog, SP5100: Check if firmware has set correct value in tcobase.
From: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Date: Thu, 17 Mar 2011 12:35:31 +0000
Cc: Priyanka Gupta <priyankag@xxxxxxxxxx>, Fitzhardinge <jeremy@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Jeremy, "linux-watchdog@xxxxxxxxxxxxxxx" <linux-watchdog@xxxxxxxxxxxxxxx>, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>, Wim, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, Mike Waychison <mikew@xxxxxxxxxx>, Van Sebroeck <wim@xxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>, Yinghai Lu <yinghai@xxxxxxxxxx>
Delivery-date: Thu, 17 Mar 2011 05:36:51 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20110317022331.GA3528@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <alpine.DEB.2.00.1103111201470.2968@kaball-desktop> <20110311222129.GA3168@xxxxxxxxxxxx> <alpine.DEB.2.00.1103161150010.3382@kaball-desktop> <alpine.DEB.2.00.1103161442210.3382@kaball-desktop> <4D80F992.10603@xxxxxxxxxx> <alpine.DEB.2.00.1103161757040.3382@kaball-desktop> <4D812180.5030102@xxxxxxxxxx> <AANLkTimNva3c_-kGA+JLCPZgrKAbwqLKaN559cwTh7cq@xxxxxxxxxxxxxx> <4D812919.30706@xxxxxxxxxx> <20110317022331.GA3528@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Alpine 2.00 (DEB 1167 2008-08-23)
On Thu, 17 Mar 2011, Konrad Rzeszutek Wilk wrote:
> On Wed, Mar 16, 2011 at 02:18:17PM -0700, Yinghai Lu wrote:
> > 
> > 
> > Stefano found SP5100 TCO watchdog driver using wrong address.
> > 
> > [    9.148536] SP5100 TCO timer: SP5100 TCO WatchDog Timer Driver v0.01
> > [    9.148628] DEBUG __ioremap_caller WARNING address=b8fe00 size=8 valid=1 
> > reserved=1
> > 
> > and e820 said that range is RAM.
> > 
> > We should check if we can use that reading out. BIOS could just program 
> > wrong address there.
> > 
> > -v2: Mike pointed out one path need one release.
> > 
> > Reported-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> > Signed-off-by:Yinghai Lu <yinghai@xxxxxxxxxx>
> > Acked-by: Mike Waychison <mikew@xxxxxxxxxx>
> I have no idea why it worked the first time b/c this:
> > +   if (request_mem_region_exclusive(val, SP5100_WDT_MEM_MAP_SIZE, "SP5100 
> > TCO")) {
> is wrong. It should have been "if (!request...")..
> With that, and with Stefano's patches (stefano/2.6.38-rc6-mm-fix) on top of 
> 2.6.39-rc0 it boots up fine.

Yinghai, thanks for the patch!
I hope that we are not going to find any more of this kind of issues
with other drivers and other BIOSes.

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>