This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH 8 of 8] xen: add "clang=y" option to build Xen wi

To: Keir Fraser <keir.xen@xxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 8 of 8] xen: add "clang=y" option to build Xen with clang/llvm instead of gcc
From: Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Date: Tue, 8 Mar 2011 10:29:03 +0000
Cc: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Tue, 08 Mar 2011 02:29:32 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C99AC006.14450%keir.xen@xxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20110307162934.GD28479@xxxxxxxxxxxxxxxxxxxxxxx> <C99AC006.14450%keir.xen@xxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.20 (2009-06-14)
At 17:01 +0000 on 07 Mar (1299517318), Keir Fraser wrote:
> On 07/03/2011 16:29, "Tim Deegan" <Tim.Deegan@xxxxxxxxxx> wrote:
> > At 14:54 +0000 on 07 Mar (1299509669), Ian Campbell wrote:
> >> Is it worth arranging for "gcc := y" when clang is not enabled? Then a
> >> whole bunch of this sort of thing devolves into the
> >> CFLAGS-$(a-particular-cc) += -Wfoo
> >> pattern.
> > 
> > Something like the attached?  It tidies up four such ifeqs, at the cost
> > of one new one to define $(gcc).
> > (4 files changed, 17 insertions(+), 16 deletions(-))
> This looks like a definite improvement in readability, to me. I'd like it to
> be applied.

Done (I'm interpreting this as an Acked-by:).


Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Principal Software Engineer, Xen Platform Team
Citrix Systems UK Ltd.  (Company #02937203, SL9 0BG)

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>