|
|
![](http://www.xen.org/images/globals/pixel.gif) |
|
|
|
|
|
|
|
xen-devel
Re: [Xen-devel] [PATCH 2 of 8] x86: add explicit size suffixes to some
On 08/03/2011 11:01, "Jan Beulich" <JBeulich@xxxxxxxxxx> wrote:
>>>> On 08.03.11 at 11:44, Tim Deegan <Tim.Deegan@xxxxxxxxxx> wrote:
>> At 09:27 +0000 on 08 Mar (1299576427), Jan Beulich wrote:
>>>>>> On 07.03.11 at 12:26, Tim Deegan <Tim.Deegan@xxxxxxxxxx> wrote:
>>>> --- a/xen/arch/x86/x86_emulate/x86_emulate.c Mon Mar 07 11:21:11 2011 +0000
>>>> +++ b/xen/arch/x86/x86_emulate/x86_emulate.c Mon Mar 07 11:21:11 2011 +0000
>>>> @@ -2678,7 +2678,7 @@ x86_emulate(
>>>> emulate_fpu_insn_memsrc("fiaddl", src.val);
>>>> break;
>>>> case 1: /* fimul m64i */
>>>> - emulate_fpu_insn_memsrc("fimul", src.val);
>>>> + emulate_fpu_insn_memsrc("fimuls", src.val);
>>>
>>> fimull.
>>
>> fimuls is what the previous code generates, but it does look like that
>> was wrong. I'll fix it, thanks.
>
> And perhaps that fix by itself should go into 4.1/4.0 too.
Done. Also I fixed the comments to read 'm32i' and also noted and fixed
src.bytes=ea.bytes=4 rather than 8.
-- Keir
> Jan
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
|
|