This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH 6 of 8] Xen: remove run_in_exception_handler() an

To: Tim Deegan <Tim.Deegan@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 6 of 8] Xen: remove run_in_exception_handler() and recode its only caller
From: Keir Fraser <keir.xen@xxxxxxxxx>
Date: Mon, 07 Mar 2011 15:05:28 +0000
Delivery-date: Mon, 07 Mar 2011 07:06:09 -0800
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:user-agent:date:subject:from:to:message-id :thread-topic:thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; bh=QU7ARcvX1l+3VqPVQvlPZuqNPeuevolshJpenaqHjz4=; b=A9awYq7eCOdvRRIwH4IiCKzxhnHLDeZnSjVVfV7E37Mg7HyZSPg9LZfT/Xl68QGlh6 UVIJoYpVZhgrZBDV1y/Kv3rqMp0XQmVOxF+t/ZM7LBMXG7L5CTJPkP+uBUCmjsICSvkG A/zak/v7P9hFD0DMykWXXJJWds+yzF4VMB8iE=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=user-agent:date:subject:from:to:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=pulDLShugRY7hgjwjrqeS1eRDwKMfHlDsQYZ2oAvT2yepTzdiZ+U/HF9OKAYOqYFmJ c/8G30Wrx07SFthjTm9n1QkttgBOE9v1sLymytJ8Xxs2fWmnjcm7QtHUTf1WcQEbwe3x 5crm4w9MccAVtFkc0ypHdsGIMgsatRCQg91T0=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <04783b003d5c5691930a.1299497183@xxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acvc2RgRC3Rwv6POPUWUo2Mg1G952Q==
Thread-topic: [Xen-devel] [PATCH 6 of 8] Xen: remove run_in_exception_handler() and recode its only caller
User-agent: Microsoft-Entourage/
On 07/03/2011 11:26, "Tim Deegan" <Tim.Deegan@xxxxxxxxxx> wrote:

> (dump_execution_state()) as its own bug-trap.
> This is needed to compile xen with clang, which can't handle using a
> function name in an asm immediate.

Actually run_in_exception_handler() does have another user, in ns16550.c.
Although non-essential, it makes the 'd' debug key much more useful when
running the UART in polled mode.

So I suggest we keep run_in_exception_handler but modify it to pass the
function pointer in (say) rAX. I think we won't easily be able to use
BUG_STR() logic but r_i_e_h is only used (directly or indirectly) in a few
places so the BUG_STR optimisation is unimportant. The only other
disadvantage is that rAX is less interesting in the state dump, but any
value the function pointer displaces can still be found in the stack dump,
albeit with likely a little extra effort.

Sound good?

 -- Keir 

> Signed-off-by: Tim Deegan <Tim.Deegan@xxxxxxxxxx>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>