This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH 6 of 8] Xen: remove run_in_exception_handler() an

To: Tim Deegan <Tim.Deegan@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 6 of 8] Xen: remove run_in_exception_handler() and recode its only caller
From: Keir Fraser <keir.xen@xxxxxxxxx>
Date: Mon, 07 Mar 2011 15:15:44 +0000
Delivery-date: Mon, 07 Mar 2011 07:16:22 -0800
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:user-agent:date:subject:from:to:message-id :thread-topic:thread-index:in-reply-to:mime-version:content-type; bh=O0rkQsHzKcaQOSJpQzvI6cpdMDdsKrsN0ZZfUC/3qeM=; b=P2GiBLzRFnX+iOytPj1Q+XZF3+JW8Agp8Vmi0fWwYbefLuE1Js87tNbyW75BGHjCS8 i0lAZ2MVouokBJG/V+8IzOidEbBsfoKf2MP+79JLhisgAEYaCp446yUx/8Go/QcO/sCG MYBhmJazPXKxpZmFMx/7seSCedpv5PjmL8oyw=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=user-agent:date:subject:from:to:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type; b=pSAW3hthPyZhI+3WLjDvzFOtpFz+dKDVmsYXI+hqYSsEo2c/VLD95s6KEIrBtJ3w3+ AhyeBUp9kDQvaMYMKuqfPq/LFl6dUZvGJAC3fZ0wu/KIkHl8cycv2w4eGrE4KkCQ9bdx sR4tUjgLeTsaH03vmTSA7UnJHAIrEh7xLTj5U=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C99AA4B8.143F7%keir.xen@xxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acvc2RgRC3Rwv6POPUWUo2Mg1G952QAAW8oZ
Thread-topic: [Xen-devel] [PATCH 6 of 8] Xen: remove run_in_exception_handler() and recode its only caller
User-agent: Microsoft-Entourage/
On 07/03/2011 15:05, "Keir Fraser" <keir.xen@xxxxxxxxx> wrote:

> On 07/03/2011 11:26, "Tim Deegan" <Tim.Deegan@xxxxxxxxxx> wrote:
>> (dump_execution_state()) as its own bug-trap.
>> This is needed to compile xen with clang, which can't handle using a
>> function name in an asm immediate.
> Actually run_in_exception_handler() does have another user, in ns16550.c.
> Although non-essential, it makes the 'd' debug key much more useful when
> running the UART in polled mode.
> So I suggest we keep run_in_exception_handler but modify it to pass the
> function pointer in (say) rAX.

Like the attached patch (against latest tip).

 -- Keir

> I think we won't easily be able to use
> BUG_STR() logic but r_i_e_h is only used (directly or indirectly) in a few
> places so the BUG_STR optimisation is unimportant. The only other
> disadvantage is that rAX is less interesting in the state dump, but any
> value the function pointer displaces can still be found in the stack dump,
> albeit with likely a little extra effort.
> Sound good?
>  -- Keir 
>> Signed-off-by: Tim Deegan <Tim.Deegan@xxxxxxxxxx>
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@xxxxxxxxxxxxxxxxxxx
>> http://lists.xensource.com/xen-devel

Attachment: 00-reintroduce-run-in-exc-handler
Description: Binary data

Xen-devel mailing list
<Prev in Thread] Current Thread [Next in Thread>