This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH]: minios: don't retrieve the address of void vari

To: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH]: minios: don't retrieve the address of void variable
From: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>
Date: Tue, 11 Jan 2011 17:39:59 +0100
Cc: Xen Devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>
Delivery-date: Tue, 11 Jan 2011 08:43:45 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <19756.34131.763123.271348@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Mail-followup-to: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>, Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>, Xen Devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>
References: <1294420140.12018.82.camel@xxxxxxxxxxxxxxxxxxxxxx> <20110107171644.GZ5820@xxxxxxxxxxxxxxxxxxxxxxx> <1294421133.12018.95.camel@xxxxxxxxxxxxxxxxxxxxxx> <20110107192940.GC5418@xxxxxxxxxxxxxxxxxxxxxxxxx> <19756.34131.763123.271348@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.12-2006-07-14
Ian Jackson, le Tue 11 Jan 2011 16:29:07 +0000, a écrit :
> When you write
>   Signed-off-by: me
> you are certifying that you personally know that the copyright status
> is good.

Mmm, that seems to have been clarified indeed. In the past I had mostly

The Signed-off-by: tag indicates that the signer was involved in the
development of the patch, or that he/she was in the patch's delivery path.

And my signed-off-by was mostly to express that I have completely
checked the patch and give my formal approval on it for inclusion. My
former acked-by, as expressed: in SubmittingPatches: “is not as
formal as Signed-off-by:.  It is a record that the acker has at least
reviewed the patch and has indicated acceptance. [...] Acked-by: does
not necessarily indicate acknowledgement of the entire patch.”, i.e. it
looked good to me without giving so formal approval.

> See the Developer's Certificate of Origin 1.1, below.
> I don't see how you, Samuel, can certify that for a patch written by
> Gianni.

Now that it's clearly stated in SubmittingPatches, I sure agree.


Xen-devel mailing list