This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] Fix stubdom-dm using "grep" improperly [and 1 mo

To: John Weekes <lists.xen@xxxxxxxxxxxxxxxxxx>, Keir Fraser <keir@xxxxxxx>, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Fix stubdom-dm using "grep" improperly [and 1 more messages]
From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date: Tue, 11 Jan 2011 16:42:49 +0000
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Tue, 11 Jan 2011 08:44:49 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4D2A94A0.6030505@xxxxxxxxxxxxxxxxxx>, <4D2AB68E.6050804@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Newsgroups: chiark.mail.xen.devel
References: <4D2A94A0.6030505@xxxxxxxxxxxxxxxxxx> <4D2AB68E.6050804@xxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
John Weekes writes ("[Xen-devel] [PATCH] Fix stubdom-dm using "grep" 
> stubdom-dm uses "grep" on "xm list" output to determine whether it is 
> already running. The existing behavior is to use "grep $domname-dm" but 
> this will result in a false-positive in the case of another domU running 
> whose name ends with the full new name; for instance, if "abctest-dm" is 
> running, a new "test-dm" will spin forever, waiting for it the end.

Urgh.  Thanks for this patch.  This code is pretty horrid stuff, I
have to say.  I have applied your fix to xen-unstable.

Keir, can you please also commit this to 4.0-testing ?  It applies

Stefano: does xl in stubdom mode still use stubdom-dm ?  If so can it
please not ?  Certainly "xm list" isn't going to work!


Xen-devel mailing list