Samuel Thibault writes ("Re: [Xen-devel] [PATCH]: minios: don't retrieve the
address of void variable"):
> Gianni Tedesco, le Fri 07 Jan 2011 17:25:33 +0000, a écrit :
> > Gianni
> Missing your Signed-off :)
> Signed-off-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>
I just also wanted to make a point about "Signed-off-by".
When you write
you are certifying that you personally know that the copyright status
is good. See the Developer's Certificate of Origin 1.1, below.
I don't see how you, Samuel, can certify that for a patch written by
Gianni. So, while I appreciate that you were trying to be helpful,
I think you should not have signed it off.
One of Gianni's colleagues who has suitable responsibilities at his
employer could sign off Gianni's patch. In this case that includes
me. So in fact I will be applying this patch in just a moment.
Also, if we go by FSF guidance very small patches (<10 lines) don't
constitute a copyright-relevant contribution if it's just a one-off so
we will sometimes take very small un-signed-off patches but only once
>From Documentation/SubmittingPatches in the Linux kernel tree:
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
Xen-devel mailing list