This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH]: minios: don't retrieve the address of void vari

To: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH]: minios: don't retrieve the address of void variable
From: Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>
Date: Fri, 7 Jan 2011 17:25:33 +0000
Cc: Xen Devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>
Delivery-date: Fri, 07 Jan 2011 09:26:50 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20110107171644.GZ5820@xxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1294420140.12018.82.camel@xxxxxxxxxxxxxxxxxxxxxx> <20110107171644.GZ5820@xxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Fri, 2011-01-07 at 17:16 +0000, Samuel Thibault wrote:
> Gianni Tedesco, le Fri 07 Jan 2011 17:08:59 +0000, a écrit :
> > Apparently this is verboten and gcc-4.5 doesn't like it.
> Damn! I'd say use the struct shared_info instead, since that's what it
> is.

Fair enough, I was just racing through trying to get it to build so
didn't have time to stop and smell the roses :)

Thanks for the incredibly prompt review of these by the way.



diff -r c55b93f3f8cf extras/mini-os/arch/x86/mm.c
--- a/extras/mini-os/arch/x86/mm.c      Fri Jan 07 15:27:30 2011 +0000
+++ b/extras/mini-os/arch/x86/mm.c      Fri Jan 07 17:04:48 2011 +0000
@@ -281,7 +281,7 @@ static void build_pagetable(unsigned lon
  * Mark portion of the address space read only.
-extern void shared_info;
+extern struct shared_info shared_info;
 static void set_readonly(void *text, void *etext)
     unsigned long start_address =

Xen-devel mailing list