This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] xl: improve vif2 parsing

To: "Gianni Tedesco (3P)" <gianni.tedesco@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] xl: improve vif2 parsing
From: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Date: Fri, 20 Aug 2010 17:22:32 +0100
Cc: Andre Przywara <andre.przywara@xxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Keir Fraser <Keir.Fraser@xxxxxxxxxxxxx>, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>
Delivery-date: Fri, 20 Aug 2010 09:22:39 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1282311269.3731.55.camel@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4C6E6E84.5020704@xxxxxxx> <4C6E6F20.3090405@xxxxxxx> <1282308116.3731.39.camel@xxxxxxxxxxxxxxxxxxxxxx> <4C6E7BE4.6090605@xxxxxxx> <1282311269.3731.55.camel@xxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Alpine 2.00 (DEB 1167 2008-08-23)
On Fri, 20 Aug 2010, Gianni Tedesco (3P) wrote:
> To be honest I am not that concerned about length of xl_cmdimpl.c since
> most of xl is straightfoward "parse a bit of config, pass results to a
> libxl call" - but libxl.c could probably use splitting up to make it
> easier to understand the subsystems within it. Splitting up
> create_domain() is probably most urgent task in xl_cmdimpl.c.

Yes, create_domain should be refactored and some code should be move to
libxl: we cannot expect all the possible libxl callers to replicate the
complexity of create_domain.

> Coding style / 80 char limit is a bit of a bummer but not sure how the
> maintainers will feel about coding style patches. Probably be OK.

I would be happy to apply code style patches, however I have to say that
greater than 80 chars lines don't bother me.

> > Btw. I saw that cpuid= is still missing in libxl, I have a version 
> > improved over the clumsy xm interface 90% ready, but will probably not 
> > able to send it out still this week.
> Yes, please patch and post. Also another thing is that 'uuid =' in the
> config file is ignored. That's on my wishlist :)
> I always look forward to seeing more patches.

Xen-devel mailing list