This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] xl: improve vif2 parsing

To: Andre Przywara <andre.przywara@xxxxxxx>
Subject: Re: [Xen-devel] [PATCH] xl: improve vif2 parsing
From: Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>
Date: Fri, 20 Aug 2010 13:41:56 +0100
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Keir Fraser <Keir.Fraser@xxxxxxxxxxxxx>, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>
Delivery-date: Fri, 20 Aug 2010 05:47:25 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4C6E6F20.3090405@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4C6E6E84.5020704@xxxxxxx> <4C6E6F20.3090405@xxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Fri, 2010-08-20 at 13:03 +0100, Andre Przywara wrote:
> Andre Przywara wrote:
> > Hi,
> > 
> > vif2 parsing relies on counted strncmp() statements. Replace this
> > with a more robust automatic version.
> No, I didn't want to leave this as an exercise to the reader, I am just
> spoiled by git send-email, so forgot to attach the patch. Sorry!
> > 
> > Signed-off-by: Andre Przywara <andre.przywara@xxxxxxx>
> >

Both patches look good to me.

> > Regards,
> > Andre.
> > 
> > P.S. If you like this, I have seen at least two more instances of the 
> > same issue that could be improved this way.
> > 

Can you say where?

You should be aware that disk config parsing is undergoing a rewrite
already so lets not duplicate efforts on that one ;)

Xen-devel mailing list