This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] xl: improve vif2 parsing

To: Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] xl: improve vif2 parsing
From: Andre Przywara <andre.przywara@xxxxxxx>
Date: Fri, 20 Aug 2010 14:58:12 +0200
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Keir Fraser <Keir.Fraser@xxxxxxxxxxxxx>, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>
Delivery-date: Fri, 20 Aug 2010 06:22:32 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1282308116.3731.39.camel@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4C6E6E84.5020704@xxxxxxx> <4C6E6F20.3090405@xxxxxxx> <1282308116.3731.39.camel@xxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird (X11/20090820)
Gianni Tedesco wrote:
On Fri, 2010-08-20 at 13:03 +0100, Andre Przywara wrote:
Andre Przywara wrote:

vif2 parsing relies on counted strncmp() statements. Replace this
with a more robust automatic version.
No, I didn't want to leave this as an exercise to the reader, I am just
spoiled by git send-email, so forgot to attach the patch. Sorry!

Signed-off-by: Andre Przywara <andre.przywara@xxxxxxx>

Both patches look good to me.


P.S. If you like this, I have seen at least two more instances of the same issue that could be improved this way.

Can you say where?
In main_networkattach() and main_network2attach().

You should be aware that disk config parsing is undergoing a rewrite
already so lets not duplicate efforts on that one ;)
I hoped you would say something like this. I see that parts of the code has issues:
* xl_cmdimpl.c is way too long (and will probably still have to grow)
* code duplication in several parameter parsers
* not reentrant safe (strtok instead of strtok_r)
* Coding style (mostly 80 character limit)

So I was hoping that code cleanup was on someone's list, that saves me from fixing many smaller things.


Btw. I saw that cpuid= is still missing in libxl, I have a version improved over the clumsy xm interface 90% ready, but will probably not able to send it out still this week.

Andre Przywara
AMD-OSRC (Dresden)
Tel: x29712

Xen-devel mailing list