Re: [Xen-devel] [PATCH] xl: improve vif2 parsing

[Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>]

On Fri, 2010-08-20 at 15:28 +0100, Christoph Egger wrote:
> On Friday 20 August 2010 15:34:29 Gianni Tedesco wrote:
> > On Fri, 2010-08-20 at 13:58 +0100, Andre Przywara wrote:
> > > Gianni Tedesco wrote:
> > > > On Fri, 2010-08-20 at 13:03 +0100, Andre Przywara wrote:
> > > >> Andre Przywara wrote:
> > > >>> Hi,
> > > >>>
> > > >>> vif2 parsing relies on counted strncmp() statements. Replace this
> > > >>> with a more robust automatic version.
> > > >>
> > > >> No, I didn't want to leave this as an exercise to the reader, I am
> > > >> just spoiled by git send-email, so forgot to attach the patch. Sorry!
> > > >>
> > > >>> Signed-off-by: Andre Przywara <andre.przywara@xxxxxxx>
> > > >
> > > > Both patches look good to me.
> > > >
> > > >>> Regards,
> > > >>> Andre.
> > > >>>
> > > >>> P.S. If you like this, I have seen at least two more instances of the
> > > >>> same issue that could be improved this way.
> > > >
> > > > Can you say where?
> > >
> > > In main_networkattach() and main_network2attach().
> >
> > You should absolutely sort this out. So I had already done a cleanup for
> > similar problem with PCI BDF's.
> 
> Yes and OS-dependent code still needs to be sorted out.

Indeed, the other changes I mentioned (plus correct safety checks) may
change the structure of the code so much that the OS-specific interfaces
will change substantially. For that reason it's at the bottom of the
list right now.

Gianni


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel