This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] RE: One question to compat model

To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxxxx>
Subject: [Xen-devel] RE: One question to compat model
From: "Jiang, Yunhong" <yunhong.jiang@xxxxxxxxx>
Date: Thu, 13 May 2010 18:00:45 +0800
Accept-language: en-US
Acceptlanguage: en-US
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Thu, 13 May 2010 03:01:48 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C8117B5E.14224%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <789F9655DD1B8F43B48D77C5D30659731E5F2771@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <C8117B5E.14224%keir.fraser@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcrxrVfRigO4XAJ7T6SYMC9ku2ZslAAAM51QAAFLEugAMG8F4AAA/dsxAABvB1A=
Thread-topic: One question to compat model

>-----Original Message-----
>From: Keir Fraser [mailto:keir.fraser@xxxxxxxxxxxxx]
>Sent: Thursday, May 13, 2010 4:48 PM
>To: Jiang, Yunhong; Jan Beulich
>Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
>Subject: Re: One question to compat model
>On 13/05/2010 09:41, "Jiang, Yunhong" <yunhong.jiang@xxxxxxxxx> wrote:
>>> Whoever implemented XENPF_getidletime decided to stuff a fake xenctl_cpumap
>>> struct within Xen rather than properly refactor the public headers. There's
>>> no reason not to move xenctl_cpumap out into xen.h.
>> A curios question. I checked the code, and notice that the
>> is only defined for __XEN__ or __XEN_TOOLS__. I can understand it is needed
>> for tools because 32bit tools can be used in 64bit dom0, but why it is
>> forbidden for kernel? To avoid it be passed as hypercall parameter? Sorry for
>> bothering if this is a stupid question :$
>I was probably being overzealous. There's no good reason not to use
>GUEST_HANDLE_64 and uint64_aligned_t outside of tools interfaces.

Althoug not related with my current patch, but curiosly, will it avoid the 
compat model issue if we use XEN_GUEST_HANDLE_64 for hypercall, especially if 
not performance critical, like struct xen_mc_fetch? (Maybe we still need 
consider the #pragma pack optoin for the struction?)


> -- Keir

Xen-devel mailing list