This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] RE: One question to compat model

To: Jan Beulich <JBeulich@xxxxxxxxxx>, Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Subject: [Xen-devel] RE: One question to compat model
From: "Jiang, Yunhong" <yunhong.jiang@xxxxxxxxx>
Date: Wed, 12 May 2010 16:50:12 +0800
Accept-language: en-US
Acceptlanguage: en-US
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 12 May 2010 01:52:16 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4BEA836C02000078000026C7@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <789F9655DD1B8F43B48D77C5D30659731E5F20E1@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <4BEA7C200200007800002687@xxxxxxxxxxxxxxxxxx> <789F9655DD1B8F43B48D77C5D30659731E5F212D@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <4BEA836C02000078000026C7@xxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcrxrVfRigO4XAJ7T6SYMC9ku2ZslAAAM51Q
Thread-topic: One question to compat model

>-----Original Message-----
>From: Jan Beulich [mailto:JBeulich@xxxxxxxxxx]
>Sent: Wednesday, May 12, 2010 4:31 PM
>To: Jiang, Yunhong
>Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
>Subject: RE: One question to compat model
>>>> "Jiang, Yunhong" <yunhong.jiang@xxxxxxxxx> 12.05.10 10:15 >>>
>>The followed small changes cayse compile failed with:
>>can't read compat/domctl.h: No such file or directory
>Sure - domctl.h must not be included from xen-mca.h in any case,
>you'll need to move the type declaration if you want to use it outside
>the domctl/sysctl set.

Thanks for remind. Yes, this header will also be included in kernel although 
this specific structure will only be used by tools.

>>How can I disable compat model now? I remember that option has been removed.
>You can't disable CONFIG_COMPAT anymore, but I think you should
>be able to tweak the CONFIG_COMPAT section in
>xen/arch/x86/cpu/mcheck/mce.c in a way to allow your new code to
>be built without doing anything compat-related for the new
>structures. But maybe removing the domctl.h dependency already
>clarifies matters.

Yes, it should be ok. But a curios question is, why the xenctl_cpumap has to be 
defined in domctl.h. It's simply a helper function. Now I have to work like 
XENPF_getidletime, passing two parameters (nr_cpus and the bitmap pointer), 
combine them in hypervisor to xenctl_cpumap and then call the xenctl_cpumap 
code. And the same to user space tools. 

Thanks for your remind.


Xen-devel mailing list