This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: One question to compat model

To: "Jiang, Yunhong" <yunhong.jiang@xxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxxxx>
Subject: [Xen-devel] Re: One question to compat model
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Wed, 12 May 2010 10:13:02 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 12 May 2010 02:14:02 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <789F9655DD1B8F43B48D77C5D30659731E5F2177@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcrxrVfRigO4XAJ7T6SYMC9ku2ZslAAAM51QAAFLEug=
Thread-topic: One question to compat model
User-agent: Microsoft-Entourage/
On 12/05/2010 09:50, "Jiang, Yunhong" <yunhong.jiang@xxxxxxxxx> wrote:

>> You can't disable CONFIG_COMPAT anymore, but I think you should
>> be able to tweak the CONFIG_COMPAT section in
>> xen/arch/x86/cpu/mcheck/mce.c in a way to allow your new code to
>> be built without doing anything compat-related for the new
>> structures. But maybe removing the domctl.h dependency already
>> clarifies matters.
> Yes, it should be ok. But a curios question is, why the xenctl_cpumap has to
> be defined in domctl.h. It's simply a helper function. Now I have to work like
> XENPF_getidletime, passing two parameters (nr_cpus and the bitmap pointer),
> combine them in hypervisor to xenctl_cpumap and then call the xenctl_cpumap
> code. And the same to user space tools.

Whoever implemented XENPF_getidletime decided to stuff a fake xenctl_cpumap
struct within Xen rather than properly refactor the public headers. There's
no reason not to move xenctl_cpumap out into xen.h.

 -- Keir

Xen-devel mailing list