This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH 1/2]xl: Add "xl uptime" command

To: Yang Hongyang <yanghy@xxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 1/2]xl: Add "xl uptime" command
From: Vincent Hanquez <vincent.hanquez@xxxxxxxxxxxxx>
Date: Thu, 13 May 2010 10:54:41 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Thu, 13 May 2010 02:55:14 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4BEBC81A.70109@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4BEBC81A.70109@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20100411 Icedove/3.0.4
On 13/05/10 10:36, Yang Hongyang wrote:
Add "xl uptime" command, a clone of "xm uptime".

Signed-off-by: Yang Hongyang<yanghy@xxxxxxxxxxxxxx>

diff -r d77a88f938c6 tools/libxl/libxl.c
--- a/tools/libxl/libxl.c       Tue May 11 14:05:28 2010 +0100
+++ b/tools/libxl/libxl.c       Fri May 14 01:25:56 2010 +0800
@@ -2629,3 +2629,23 @@

      return rc;
+unsigned long libxl_get_start_time(struct libxl_ctx *ctx, uint32_t domid)
+    char *dompath = libxl_xs_get_dompath(ctx, domid);
+    unsigned long s_time = 0;
+    char *start_time = NULL;
+    char *vm_path = NULL;
+    vm_path = libxl_xs_read(ctx, XBT_NULL, libxl_sprintf(ctx, "%s/vm", 
+    start_time = libxl_xs_read(ctx, XBT_NULL, libxl_sprintf(ctx, 
"%s/start_time", vm_path));
+    if (start_time == NULL) {
+        XL_LOG_ERRNOVAL(ctx, XL_LOG_ERROR, -1,
+            "Can't get start time of domain '%d'", domid);
+        return -1;
+    }
+    s_time = strtoul(start_time, NULL, 10);
+    return s_time;

this function should more than likely return a uint64_t or a uint32_t, but certainly not an unsigned long. and since it apply to a domain it should be call libxl_domain_get_start_time.

I find this command basically useless, since on restore the "start_time" is not kept. do we actually need this ?


Xen-devel mailing list