This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] vncpassword support in libxl

To: Gihan Munasinghe <GMunasinghe@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] vncpassword support in libxl
From: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Date: Thu, 6 May 2010 17:02:17 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Thu, 06 May 2010 09:08:14 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4BE2E434.6040001@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4BE2D9B9.8010908@xxxxxxxxxxxx> <4BE2E434.6040001@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Alpine 2.00 (DEB 1167 2008-08-23)
On Thu, 6 May 2010, Gihan Munasinghe wrote:
> Guys
> When trying to move xen4.0 and libxl I found that libxl does not support 
> vncpassword with in the device model.
> Was there are particular reason this feature is not implemented . To get 
> our vms ported in to xen4 and to change our management stack to use 
> libxl. I have done the following patch what do you guys think.
> Thanks 
> Gihan

The indentation is often wrong and sometimes you are adding\removing
blank lines for no reason.
But apart from this small cosmetic issues the patch looks good.

Acked-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>

Xen-devel mailing list