WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 2/2] reap the blktapctl thread and notify the tap

To: "James Song" <jsong@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 2/2] reap the blktapctl thread and notify the tapdisk backend driver to release resource like memory..
From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date: Thu, 6 May 2010 17:01:41 +0100
Cc: Jim Fehlig <JFEHLIG@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 06 May 2010 09:09:16 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4BE170FE0200002000085C39@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Newsgroups: chiark.mail.xen.devel
References: <4BE170FE0200002000085C39@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
James Song writes ("[Xen-devel] [PATCH 2/2] reap the blktapctl thread and 
notify the tapdisk backend driver to release resource like memory.."):
> I write a new patch for this issue, which modified qemu code.  So
> Ian, could you take a look this patch,too.

As far as I can see the effect here is to catch SIGINT in order to do
some kind of cleanup.  I don't think that is right.  qemu could quite
easily crash (and does!) so it is not right for cleanup to happen in
qemu.

If there is any cleanup that needs doing it needs to be done by qemu's
caller.

Reading the message you refer to, surely it should be the job of the
toolstack (xend or libxl) to ensure that the backends are instructed
to do all necessary releasing ?

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel