This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] vncpassword support in libxl

To: Gihan Munasinghe <GMunasinghe@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] vncpassword support in libxl
From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date: Thu, 6 May 2010 17:07:42 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 06 May 2010 09:12:23 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4BE2E434.6040001@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Newsgroups: chiark.mail.xen.devel
References: <4BE2D9B9.8010908@xxxxxxxxxxxx> <4BE2E434.6040001@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Gihan Munasinghe writes ("[Xen-devel] [PATCH] vncpassword support in libxl"):
> When trying to move xen4.0 and libxl I found that libxl does not support 
> vncpassword with in the device model.
> Was there are particular reason this feature is not implemented . To get 
> our vms ported in to xen4 and to change our management stack to use 
> libxl. I have done the following patch what do you guys think.

It looks like a mostly reasonable patch, thanks.  However you have
made a couple of apparently accidental changes:

-        libxl_exec(null, logfile_w, logfile_w,
+       libxl_exec(null, logfile_w, logfile_w,
-    printf("Parsing config file %s\n", config_file);

and so on.

Could people please review your patches by eye - yes, read every line
- before sending ?

In this case, please resubmit with only the necessary changes.  While
you're at it, you should probably ensure that you submit a patch which
doesn't introduce tabs.  I don't mind them but I know some people do.
You may want (setq indent-tabs-mode nil) in Emacs.


Xen-devel mailing list