WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] vncpassword support in libxl

Ian Jackson wrote:
Stefano Stabellini writes ("Re: [Xen-devel] [PATCH] vncpassword support in 
libxl"):
The indentation is often wrong and sometimes you are adding\removing
blank lines for no reason.
But apart from this small cosmetic issues the patch looks good.

You missed that he removed this line:

-    printf("Parsing config file %s\n", config_file);

This demonstrates why patches with spurious stuff in should be
rejected - it's too easy to miss a mistake when scanning past a lot of
spurious changes.

Ian.


Yes my mad will do the changes and resubmit again


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel