This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] Fix xenconsole after aborted save

To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Fix xenconsole after aborted save
From: Neil Turton <nturton@xxxxxxxxxxxxxx>
Date: Wed, 22 Apr 2009 17:15:17 +0100
Cc: Jiri Denemark <jdenemar@xxxxxxxxxx>, Chris Lalancette <clalance@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Gerd Hoffmann <kraxel@xxxxxxxxxx>
Delivery-date: Wed, 22 Apr 2009 09:17:31 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C614AE59.9293%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <C614AE59.9293%keir.fraser@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird (X11/20090320)
Keir Fraser wrote:
> The suspend_cancel hook you are thinking of is for any PV devices which *do*
> need to know that a suspend was cancelled. Netaccel does for some reason
> which I cannot recall.

For the record, netaccel needs to remove any mappings of the hardware
during the suspend callback since those mappings are not valid after the
suspend has completed.  Those hardware mappings (or the mappings
appropriate for the new machine) are restored on resume as a result of
the standard netfront/netback connection being re-established.  If the
suspend is cancelled, the netfront/netback connection stays in place but
the hardware mappings need to be re-established which is why the
suspend_cancel callback is used.

Cheers, Neil.

Xen-devel mailing list