This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] Fix xenconsole after aborted save

To: Gerd Hoffmann <kraxel@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Fix xenconsole after aborted save
From: Jiri Denemark <jdenemar@xxxxxxxxxx>
Date: Mon, 20 Apr 2009 16:04:36 +0200
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 20 Apr 2009 07:05:38 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <49EC7AE1.5060807@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20090420132353.GA20653@xxxxxxxxxx> <49EC7AE1.5060807@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.18 (2008-05-17)
On Mon, Apr 20, 2009 at 15:38:41 +0200, Gerd Hoffmann wrote:
> On 04/20/09 15:23, Jiri Denemark wrote:
>> Hi.
>> When a domain is resumed after aborted save (e.g., because of insufficient
>> space on a device where the domain is being saved), xm console cannot
>> send/read any data. The reason is that the event channel used by xenconsole
>> stays unbound.
>> This patch modifies xenconsoled to check current status of open event 
>> channels
>> and rebind them if necessary.
> close() + open() is the sledge hammer approach (will work though).  Just  
> unbind(local_port) should be enough.

It doesn't close() and open(), it just calls xc_evtchn_bind_interdomain() in
case the event channel is unbound. The close() + open() combination was there
before... I haven't touched that code except for skipping it when only rebind
is required.

Xen-devel mailing list