This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] Fix xenconsole after aborted save

To: Jiri Denemark <jdenemar@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Fix xenconsole after aborted save
From: Gerd Hoffmann <kraxel@xxxxxxxxxx>
Date: Mon, 20 Apr 2009 16:09:25 +0200
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 20 Apr 2009 07:09:52 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20090420140436.GB18963@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20090420132353.GA20653@xxxxxxxxxx> <49EC7AE1.5060807@xxxxxxxxxx> <20090420140436.GB18963@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1b3pre) Gecko/20090324 Fedora/3.0-2.1.beta2.fc11 Thunderbird/3.0b2
On 04/20/09 16:04, Jiri Denemark wrote:
On Mon, Apr 20, 2009 at 15:38:41 +0200, Gerd Hoffmann wrote:
On 04/20/09 15:23, Jiri Denemark wrote:
This patch modifies xenconsoled to check current status of open event channels
and rebind them if necessary.
close() + open() is the sledge hammer approach (will work though).  Just
unbind(local_port) should be enough.

It doesn't close() and open(), it just calls xc_evtchn_bind_interdomain() in
case the event channel is unbound. The close() + open() combination was there
before... I haven't touched that code except for skipping it when only rebind
is required.

Oh, ok, got the logic wrong.  The patch looks fine to me then.


Xen-devel mailing list