This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] Fix xenconsole after aborted save

To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Fix xenconsole after aborted save
From: Jiri Denemark <jdenemar@xxxxxxxxxx>
Date: Mon, 20 Apr 2009 17:58:14 +0200
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Gerd Hoffmann <kraxel@xxxxxxxxxx>
Delivery-date: Mon, 20 Apr 2009 09:00:13 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C612481D.9071%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20090420140436.GB18963@xxxxxxxxxx> <C612481D.9071%keir.fraser@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.18 (2008-05-17)
> > It doesn't close() and open(), it just calls xc_evtchn_bind_interdomain() in
> > case the event channel is unbound. The close() + open() combination was 
> > there
> > before... I haven't touched that code except for skipping it when only 
> > rebind
> > is required.
> And actually that is a bug, since you will leak the old dom->local_port.
Ah, ok, thanks for fixing that...

> I checked in an alternative patch as c/s 19561, so please take a look and
> test that resolves your issue.
Yes, the alternative patch works fine.
> Another thing to note is I think this problem can only occur if the domU
> does not support suspend cancellation
Sure, the problem only occurs for kernels without SUSPEND_CANCEL feature.


Xen-devel mailing list