This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] do_domctl and EAGAIN

To: Juergen Gross <juergen.gross@xxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] do_domctl and EAGAIN
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Tue, 07 Apr 2009 09:49:00 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Tue, 07 Apr 2009 01:49:27 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <49DB1077.5070601@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acm3W+c3bmPgQaLpTBywhDYtBl8T3AAAcqa6
Thread-topic: [Xen-devel] do_domctl and EAGAIN
User-agent: Microsoft-Entourage/
On 07/04/2009 09:36, "Juergen Gross" <juergen.gross@xxxxxxxxxxxxxx> wrote:

> XEN_SYSCTL_pm_op (this one is tested by caller)

Yes, and indeed has to be checked by the caller, rather than hidden, since
it's an odd EAGAIN-with-side-effects.

> xenstore calls (tested by caller)

Not really hypercalls as such.

> mmuext_op (NOT always checked by caller)

Nah, that doesn't return EINTR. EAGAIN/EINTR is used a lot in Xen's mm.c,
but shouldn't leak into hypercall return values. That'd be a
non-backward-compatible bug.

 -- Keir

Xen-devel mailing list