[Xen-devel] do_domctl and EAGAIN

To:	"xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject:	[Xen-devel] do_domctl and EAGAIN
From:	Juergen Gross <juergen.gross@xxxxxxxxxxxxxx>
Date:	Tue, 07 Apr 2009 09:04:58 +0200
Delivery-date:	Tue, 07 Apr 2009 00:05:30 -0700
Dkim-signature:	v=1; a=rsa-sha256; c=simple/simple; d=ts.fujitsu.com; i=juergen.gross@xxxxxxxxxxxxxx; q=dns/txt; s=s1536b; t=1239087985; x=1270623985; h=from:sender:reply-to:subject:date:message-id:to:cc: mime-version:content-transfer-encoding:content-id: content-description:resent-date:resent-from:resent-sender: resent-to:resent-cc:resent-message-id:in-reply-to: references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:list-owner:list-archive; z=From:=20Juergen=20Gross=20<juergen.gross@xxxxxxxxxxxxxx> \|Subject:=20do_domctl=20and=20EAGAIN\|Date:=20Tue,=2007=20 Apr=202009=2009:04:58=20+0200\|Message-ID:=20<49DAFB1A.303 0405@xxxxxxxxxxxxxx>\|To:=20"xen-devel@xxxxxxxxxxxxxxxxxxx "=20<xen-devel@xxxxxxxxxxxxxxxxxxx>\|MIME-Version:=201.0 \|Content-Transfer-Encoding:=207bit; bh=KdBvfeV/75sjVxpZWSv1ItadQCeXz5nsTbIu2ebdPtA=; b=gxFzt8si5yax9qQEL/viD0Lg4knHJyRNFQR8V8qF8hVN+Tag5lBRHtMn LlIrtwGTAguatICwaqesxHW+l8rIpCnxxf9EDKGQwCAhpWsQLfoZC2JAz hfb1e9qUdmpUXB91KivBmgIeqNwHwYmflz/Gn2nncATV3QWhxIxdKShZ7 YJXlQPcsiDTQ8WJq3xvTTI1n2Q1Vb2L2R+K9ujqbrWCsa9NB1sgYpVQ0g SGHVsYy7tF7EU76QdJJBE1NyCFuB2;
Domainkey-signature:	s=s1536a; d=ts.fujitsu.com; c=nofws; q=dns; h=X-SBRSScore:X-IronPort-AV:Received:X-IronPort-AV: Received:Received:Message-ID:Date:From:Organization: User-Agent:MIME-Version:To:Subject:X-Enigmail-Version: Content-Type:Content-Transfer-Encoding; b=AfsZQuA8+xjTzE3RB4rFxbXFylkplBS+obwq9u69EVOZns31CI+Xx2Z4 HhxDP5DLWkzWrgzj6+iaaTOdiJfhspirQB9yBcfGJX01OU5DMfjJhMrN3 daGOQiUQof+kEymkh9VC4vjpKlzW6WPEDwnPmDbDzQ0637Qc+TE5fy4gO tebNNNENuCrX8fFgJKZrk1Qm+LWfxzhIz5yU7zm+ZOjbF4AYPlMU2kJDh bvl0ZO4z3Jhj3qyvKKusmcrnqgbZR;
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization:	Fujitsu Technology Solutions
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent:	Mozilla-Thunderbird 2.0.0.19 (X11/20090103)

Hi,

certain domctl hypercalls (and possibly others as well) might fail with errno
EAGAIN. This case seems to be tested only in very few places, e.g. in
xc_domain_destroy.

Is there any reason why this case isn't handled in do_domctl?
Shouldn't EINTR be handled as well?

The other solution would be to have two versions of do_domctl, one of them
looping in case of EAGAIN or EINTR.

I suspect this lack of errno-testing could lead to very sporadic failures...


Juergen

-- 
Juergen Gross                 Principal Developer Operating Systems
TSP ES&S SWE OS6                       Telephone: +49 (0) 89 636 47950
Fujitsu Technolgy Solutions               e-mail: juergen.gross@xxxxxxxxxxxxxx
Otto-Hahn-Ring 6                        Internet: ts.fujitsu.com
D-81739 Muenchen                 Company details: ts.fujitsu.com/imprint.html

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

[Xen-devel] do_domctl and EAGAIN