This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] do_domctl and EAGAIN

To: Juergen Gross <juergen.gross@xxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] do_domctl and EAGAIN
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Tue, 07 Apr 2009 08:20:09 +0100
Delivery-date: Tue, 07 Apr 2009 00:20:37 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <49DAFB1A.3030405@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acm3TzxN7Lg8IROhTyuh4XhCcbTGYQAAgv+N
Thread-topic: [Xen-devel] do_domctl and EAGAIN
User-agent: Microsoft-Entourage/
Only DOMCTL_destroydomain returns EAGAIN. No domctl returns EINTR.

 -- Keir

On 07/04/2009 08:04, "Juergen Gross" <juergen.gross@xxxxxxxxxxxxxx> wrote:

> Hi,
> certain domctl hypercalls (and possibly others as well) might fail with errno
> EAGAIN. This case seems to be tested only in very few places, e.g. in
> xc_domain_destroy.
> Is there any reason why this case isn't handled in do_domctl?
> Shouldn't EINTR be handled as well?
> The other solution would be to have two versions of do_domctl, one of them
> looping in case of EAGAIN or EINTR.
> I suspect this lack of errno-testing could lead to very sporadic failures...
> Juergen

Xen-devel mailing list