This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


RE: [Xen-devel] [PATCH] Dom0 Kernel - Fixes for saving/restoringMSI/MSI-

To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH] Dom0 Kernel - Fixes for saving/restoringMSI/MSI-X across Dom0 S3
From: "Shan, Haitao" <haitao.shan@xxxxxxxxx>
Date: Mon, 24 Nov 2008 21:45:33 +0800
Accept-language: en-US
Acceptlanguage: en-US
Cc: "'xen-devel@xxxxxxxxxxxxxxxxxxx'" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 24 Nov 2008 05:47:06 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C5504899.2950B%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <492AA0F0.76E4.0078.0@xxxxxxxxxx> <C5504899.2950B%keir.fraser@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AclOLK6B7McgVLofEd268QAX8io7RQADZeXQ
Thread-topic: [Xen-devel] [PATCH] Dom0 Kernel - Fixes for saving/restoringMSI/MSI-X across Dom0 S3
No problem, given that MSI is disabled by default now.
Actually, this patch is a fix for xen3.3 and some distributions based on 
xen3.3, where MSI is still available via options.
The bug shows: S3 failed when SATA mode is set to be AHCI. I think Jan might 
know this bug already.
At least, it can be viewed as a workaround if someone is really in need of that.

Shan Haitao

-----Original Message-----
From: Keir Fraser [mailto:keir.fraser@xxxxxxxxxxxxx] 
Sent: 2008年11月24日 20:04
To: Jan Beulich; Shan, Haitao
Cc: 'xen-devel@xxxxxxxxxxxxxxxxxxx'
Subject: Re: [Xen-devel] [PATCH] Dom0 Kernel - Fixes for 
saving/restoringMSI/MSI-X across Dom0 S3

On 24/11/08 11:41, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:

>>>> "Shan, Haitao" <haitao.shan@xxxxxxxxx> 24.11.08 12:03 >>>
>> With this patch, MSI/MSI-X capabilities and tables are saved in Dom0 when
>> S3 and restored when resume. Actually, this is also the approach that
>> kernel takes. The only concern is that Dom0 should not touch MSI/MSI-X,
>> they are owned by VMM itself. Maybe adding a hypercall to instruct Xen to
>> do the saving/restoring is good. I wonder whether the reason is strong
>> enough for adding a hypercall for such purpose.
> Is it at all necessary to use a hypercall here? Shouldn't Xen itself be able
> to
> do the necessary saving/restoring (just like it does for IO-APIC)?

I was thinking the same thing. Haitao: shall I hold off on your original
patch while we think about this?

 -- Keir

Xen-devel mailing list