This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] Dom0 Kernel - Fixes for saving/restoringMSI/MSI-

To: Jan Beulich <jbeulich@xxxxxxxxxx>, Haitao Shan <haitao.shan@xxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Dom0 Kernel - Fixes for saving/restoringMSI/MSI-X across Dom0 S3
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Mon, 24 Nov 2008 12:03:37 +0000
Cc: "'xen-devel@xxxxxxxxxxxxxxxxxxx'" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 24 Nov 2008 04:04:18 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <492AA0F0.76E4.0078.0@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AclOLK6B7McgVLofEd268QAX8io7RQ==
Thread-topic: [Xen-devel] [PATCH] Dom0 Kernel - Fixes for saving/restoringMSI/MSI-X across Dom0 S3
User-agent: Microsoft-Entourage/
On 24/11/08 11:41, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:

>>>> "Shan, Haitao" <haitao.shan@xxxxxxxxx> 24.11.08 12:03 >>>
>> With this patch, MSI/MSI-X capabilities and tables are saved in Dom0 when
>> S3 and restored when resume. Actually, this is also the approach that
>> kernel takes. The only concern is that Dom0 should not touch MSI/MSI-X,
>> they are owned by VMM itself. Maybe adding a hypercall to instruct Xen to
>> do the saving/restoring is good. I wonder whether the reason is strong
>> enough for adding a hypercall for such purpose.
> Is it at all necessary to use a hypercall here? Shouldn't Xen itself be able
> to
> do the necessary saving/restoring (just like it does for IO-APIC)?

I was thinking the same thing. Haitao: shall I hold off on your original
patch while we think about this?

 -- Keir

Xen-devel mailing list