This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] [PATCH] Dom0 Kernel - Fixes for saving/restoring MSI/MSI-X a

To: 'Keir Fraser' <keir.fraser@xxxxxxxxxxxxx>
Subject: [Xen-devel] [PATCH] Dom0 Kernel - Fixes for saving/restoring MSI/MSI-X across Dom0 S3
From: "Shan, Haitao" <haitao.shan@xxxxxxxxx>
Date: Mon, 24 Nov 2008 19:03:19 +0800
Accept-language: en-US
Acceptlanguage: en-US
Cc: "'xen-devel@xxxxxxxxxxxxxxxxxxx'" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 24 Nov 2008 03:03:49 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AclOJEJR+OwpiDmMQBGSwUTLsM7WbA==
Thread-topic: [PATCH] Dom0 Kernel - Fixes for saving/restoring MSI/MSI-X across Dom0 S3
Hi, Keir,

This patch is a bugfix for saving and restoring MSI/MSI-X across S3. Currently, 
Dom0's PCI layer unmaps MSI when S3 and maps them back when resuming. However, 
this triggers unexpected behaviors. For example, if the drivers still holds 
that irq at the point of unmapping MSI, Xen will force unbind that pirq. But 
after resume, we have no mechanism to rebind that pirq. The device can not 
receive interrupt then.
With this patch, MSI/MSI-X capabilities and tables are saved in Dom0 when S3 
and restored when resume. Actually, this is also the approach that kernel 
takes. The only concern is that Dom0 should not touch MSI/MSI-X, they are owned 
by VMM itself. Maybe adding a hypercall to instruct Xen to do the 
saving/restoring is good. I wonder whether the reason is strong enough for 
adding a hypercall for such purpose.

So Keir, maybe you can tell what is your prefer?

Best Regards
Haitao Shan

Attachment: msi.patch
Description: msi.patch

Xen-devel mailing list