WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [PATCH][VNC Auth] Fix qemu-dm becomes defunct when rebooting

To: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>, "Daniel P. Berrange" <berrange@xxxxxxxxxx>, Anthony Liguori <aliguori@xxxxxxxxxx>
Subject: [Xen-devel] [PATCH][VNC Auth] Fix qemu-dm becomes defunct when rebooting hvm domain
From: Masami Watanabe <masami.watanabe@xxxxxxxxxxxxxx>
Date: Thu, 26 Oct 2006 07:07:32 +0900
Cc: Ian Pratt <m+Ian.Pratt@xxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx, "Zheng, Jeff" <jeff.zheng@xxxxxxxxx>, masami.watanabe@xxxxxxxxxxxxxx
Delivery-date: Wed, 25 Oct 2006 15:09:11 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Hi,

Sorry, I should not have removed infomation on xend.

  image.py, line 399, in configVNC
    config.remove(['vncpasswd', vncpasswd_vmconfig])

When vncpasswd is removed, qemu-dm cannot be started in reboot of hvm domain.
Because necessary information disappears.
It cannot be helped though information in config list remains in xenstore.

This patch corrects above.

Regards,
Masami


------------------------------------
diff -r a661566745ae tools/python/xen/xend/image.py
--- a/tools/python/xen/xend/image.py    Tue Oct 24 16:46:02 2006 +0100
+++ b/tools/python/xen/xend/image.py    Wed Oct 25 16:55:52 2006 +0900
@@ -395,9 +395,6 @@ class HVMImageHandler(ImageHandler):
             if vncpasswd != '':
                 self.vm.storeVm("vncpasswd", vncpasswd)

-        # remove password
-        config.remove(['vncpasswd', vncpasswd_vmconfig])
-
         return ret

     def createDeviceModel(self):
------------------------------------



On Wed, 25 Oct 2006 21:43:11 +0100, Keir Fraser wrote:
> The patch has been in for nearly a week, c/s 11840:02506a744315. Did you
> check before asking?
> 
>  -- Keir
> 
> On 25/10/06 7:00 pm, "Daniel P. Berrange" <berrange@xxxxxxxxxx> wrote:
> 
> > Hi Kier / Ewan,
> > 
> > Can we get Masami's VNC password patch into xen-unstable.
> > 
> > Regards,
> > Dan
> > 
> > On Tue, Oct 10, 2006 at 09:04:09AM -0500, Anthony Liguori wrote:
> >> Daniel P. Berrange wrote:
> >>> On Thu, Oct 05, 2006 at 10:28:15AM +0900, Masami Watanabe wrote:
> >>>  
> >>>> Hi all,
> >>>> 
> >>>> This is take 4 on VNC authentification.
> >>>> 
> >>>> The specification is as mentioned at
> >>>> http://lists.xensource.com/archives/html/xen-devel/2006-09/msg00666.html
> >>>> (However, password came to describe plain text)
> >>>> 
> >>>> The difference is follows.
> >>>> - protocol_authtype() without the necessity was deleted.
> >>>> - The check on the protocol version was added.
> >>>> - And, some small modification.
> >>>>    
> >>> 
> >>> The patch loooks good to me - unless Anthony spots any further issues in
> >>> the VNC auth code, I'd say this is worth commiting to xen-unstable.hg
> >>> whe 3.0.4 development opens up.
> >>>  
> >> 
> >> Looks good to me too.  Thanks Masami!
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel