This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [PATCH][XEN] remove include checks from domctl.h and sys

To: Hollis Blanchard <hollisb@xxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH][XEN] remove include checks from domctl.h and sysctl.h
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Tue, 05 Sep 2006 22:31:54 +0100
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, xen-ppc-devel <xen-ppc-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Tue, 05 Sep 2006 14:30:47 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <1157484829.20425.44.camel@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcbRMrTj87VJ5z0lEduQ/AAX8io7RQ==
Thread-topic: [PATCH][XEN] remove include checks from domctl.h and sysctl.h
User-agent: Microsoft-Entourage/
On 5/9/06 20:33, "Hollis Blanchard" <hollisb@xxxxxxxxxx> wrote:

>> That's not going to be true for PowerPC and soon IA64.
>> Because of Xen's use of pointers for hypercall parameters, we need the
>> kernel to translate virtual addresses to physical addresses. That means
>> any time a new hypercall is introduced to the tools, our kernel needs to
>> change to translate the new data structure.
> Therefore, the following patch is required. Please apply.
> [XEN] remove include checks from domctl.h and sysctl.h
> Signed-off-by: Hollis Blanchard <hollisb@xxxxxxxxxx>

No thanks: we really don't want inclusion of those header files to slip into
use in kernel builds. I suggest limiting your touching of domctl/sysctl to
one source file in Linux, and compile that file with -D__XEN_TOOLS__. This
will help ensure that you can at least limit the kernel tainting to
one (potentially upgradeable) module.

 -- Keir

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>