This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [XenPPC] [Xen-devel] [PATCH][XEN] remove include checks from domctl.

To: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Subject: Re: [XenPPC] [Xen-devel] [PATCH][XEN] remove include checks from domctl.h and sysctl.h
From: Hollis Blanchard <hollisb@xxxxxxxxxx>
Date: Tue, 05 Sep 2006 15:17:22 -0500
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, xen-ppc-devel <xen-ppc-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Tue, 05 Sep 2006 13:17:21 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <1157484829.20425.44.camel@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: IBM Linux Technology Center
References: <E1GGznZ-00046D-G5@xxxxxxxxxxxxxxxxxxxxx> <1156780746.28490.36.camel@xxxxxxxxxxxxxxxxxxxxx> <1157484829.20425.44.camel@xxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Tue, 2006-09-05 at 14:33 -0500, Hollis Blanchard wrote:
> On Mon, 2006-08-28 at 10:59 -0500, Hollis Blanchard wrote:
> > On Sat, 2006-08-26 at 15:10 +0000, Xen patchbot-unstable wrote:
> > > 
> > > >From here on we hope to maintain dom0 kernel compatibility. This
> > > promise is not extended to tool compatibility beyond the existing
> > > guarantee that compatibility will not be broken within a three-level
> > > stable release [3.0.2, 3.0.3, etc.]. 
> > 
> > That's not going to be true for PowerPC and soon IA64.
> > 
> > Because of Xen's use of pointers for hypercall parameters, we need the
> > kernel to translate virtual addresses to physical addresses. That means
> > any time a new hypercall is introduced to the tools, our kernel needs to
> > change to translate the new data structure.
> Therefore, the following patch is required. Please apply.
> [XEN] remove include checks from domctl.h and sysctl.h
> Signed-off-by: Hollis Blanchard <hollisb@xxxxxxxxxx>
> diff -r 2017f6e92bf8 xen/include/public/domctl.h
> --- a/xen/include/public/domctl.h       Thu Aug 31 14:46:28 2006 +0100
> +++ b/xen/include/public/domctl.h       Tue Sep 05 14:30:11 2006 -0500
> @@ -9,10 +9,6 @@
>  #ifndef __XEN_PUBLIC_DOMCTL_H__
>  #define __XEN_PUBLIC_DOMCTL_H__
> -
> -#if !defined(__XEN__) && !defined(__XEN_TOOLS__)
> -#error "domctl operations are intended for use by node control tools only"
> -#endif
>  #include "xen.h"

A very similar problem hits us when building Linux. Without __XEN__ or
__XEN_TOOLS__ defined, Linux gets a __XEN_INTERFACE_VERSION__ of 0, and
so the current API will never be used (regardless of what the tools
tried to do).

Are you intentionally requiring that Linux do this? If so, in which
Linux header file would you like this to go?

Or perhaps, since the kernel is acting as a proxy for the tools, you
would rather see this?
#define __XEN_TOOLS__

Hollis Blanchard
IBM Linux Technology Center

Xen-devel mailing list