This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] [PATCH][XEND] Fix yet another information-destroying backtra

To: Ewan Mellor <ewan@xxxxxxxxxxxxx>, Alistair Tse <atse@xxxxxxxxxxxxx>
Subject: [Xen-devel] [PATCH][XEND] Fix yet another information-destroying backtrace in Xend
From: Hollis Blanchard <hollisb@xxxxxxxxxx>
Date: Tue, 05 Sep 2006 16:18:31 -0500
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Tue, 05 Sep 2006 14:18:33 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: IBM Linux Technology Center
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Every time you call traceback.print_exc() from an exception handler, you
throw away all the traceback information you've accumulated to get to
that spot. I'm not going to do a global find/replace without testing,
but I know the below patch works and is needed.

Fix yet another information-destroying backtrace in Xend.
Signed-off-by: Hollis Blanchard <hollisb@xxxxxxxxxx>

diff -r 343c37f11a8b tools/python/xen/xend/server/SrvDaemon.py
--- a/tools/python/xen/xend/server/SrvDaemon.py Tue Sep 05 14:44:20 2006 -0500
+++ b/tools/python/xen/xend/server/SrvDaemon.py Tue Sep 05 16:12:25 2006 -0500
@@ -293,7 +293,7 @@ class Daemon:
         except Exception, ex:
             print >>sys.stderr, 'Exception starting xend:', ex
             if XEND_DEBUG:
-                traceback.print_exc()
+                raise
             log.exception("Exception starting xend (%s)" % ex)
             if status:

Hollis Blanchard
IBM Linux Technology Center

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [PATCH][XEND] Fix yet another information-destroying backtrace in Xend, Hollis Blanchard <=