This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [XenPPC] [Xen-devel] [PATCH][XEN] remove include checks from domctl.

To: Hollis Blanchard <hollisb@xxxxxxxxxx>
Subject: Re: [XenPPC] [Xen-devel] [PATCH][XEN] remove include checks from domctl.h and sysctl.h
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Tue, 05 Sep 2006 23:10:40 +0100
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, xen-ppc-devel <xen-ppc-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Tue, 05 Sep 2006 15:09:38 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <1157487442.20425.51.camel@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcbROB9KXeZfFD0rEduQ/AAX8io7RQ==
Thread-topic: [XenPPC] [Xen-devel] [PATCH][XEN] remove include checks from domctl.h and sysctl.h
User-agent: Microsoft-Entourage/
On 5/9/06 21:17, "Hollis Blanchard" <hollisb@xxxxxxxxxx> wrote:

> A very similar problem hits us when building Linux. Without __XEN__ or
> __XEN_TOOLS__ defined, Linux gets a __XEN_INTERFACE_VERSION__ of 0, and
> so the current API will never be used (regardless of what the tools
> tried to do).
> Are you intentionally requiring that Linux do this? If so, in which
> Linux header file would you like this to go?

It's defined for you in drivers/xen/Kconfig. All other arches then fold it
into CFLAGS in arch/<arch>/Makefile. This ensures that it is defined
absolutely *everywhere*, avoiding the possibility of having it defined as
latest versionin one place and zero in an other (which would be really
confusing). That's what I'd recommend for powerpc as well, even though it
probably requires you to modify a file that's otherwise 'Xen clean'.

> Or perhaps, since the kernel is acting as a proxy for the tools, you
> would rather see this?
> #define __XEN_TOOLS__

Yes, but only in the file that does the virt-to-phys conversions on the
domctl/sysctl interfaces.

 -- Keir

Xen-devel mailing list