This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] PATCH: makes acm_setup arch independant

To: Tristan Gingold <Tristan.Gingold@xxxxxxxx>
Subject: Re: [Xen-devel] PATCH: makes acm_setup arch independant
From: Hollis Blanchard <hollisb@xxxxxxxxxx>
Date: Tue, 05 Sep 2006 15:45:56 -0500
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 05 Sep 2006 13:45:50 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <200609051010.51781.Tristan.Gingold@xxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: IBM Linux Technology Center
References: <200609051010.51781.Tristan.Gingold@xxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Tue, 2006-09-05 at 10:10 +0200, Tristan Gingold wrote:
> Hi,
> the acm_setup code use a multiboot descriptor to extract the policy module.
> Because multiboot is not used on every platform, I slightly changed the 
> interface: acm_setup now use buffer/len arguments.
> The module extraction code is moved to arch/x86/setup.c
> I have just tested this code on ia64.
> The code compiles on x86 but I am unable to test it.

Hi Tristan, when you send patches like this that impact all the
architectures, could you please:
1. Include all architectures in the same patch. Do not just change x86
and omit IA64 and PowerPC. That way you won't break the build, and all
the code can be evaluated in the same email.
2. CC xen-ppc-devel as a heads-up.


Hollis Blanchard
IBM Linux Technology Center

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>