This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] PATCH: makes acm_setup arch independant

To: Stefan Berger <stefanb@xxxxxxxxxx>
Subject: Re: [Xen-devel] PATCH: makes acm_setup arch independant
From: Hollis Blanchard <hollisb@xxxxxxxxxx>
Date: Wed, 06 Sep 2006 15:00:46 -0500
Cc: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, xen-ppc-devel@xxxxxxxxxxxxxxxxxxx, Tristan Gingold <Tristan.Gingold@xxxxxxxx>
Delivery-date: Wed, 06 Sep 2006 13:00:50 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <OF69ECB68C.76A3E1BD-ON852571E1.006AEFFF-852571E1.006CDFC1@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: IBM Linux Technology Center
References: <OF69ECB68C.76A3E1BD-ON852571E1.006AEFFF-852571E1.006CDFC1@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Wed, 2006-09-06 at 15:49 -0400, Stefan Berger wrote:
> A minor issue is whether as much as possible of the ACM-specific code
> should be kept inside the acm directory and we use #ifdefs like
> #if defined(__i386__)
> #if defined(__x86_64__)
> to compile architecture-specific functions there, or whether functions like
> the extract_acm_policy below should be surrounded by #ifdef ACM_SECURITY
> and they can stay inside the architecture-specific code. The assumption
> would be that no one boots with an ACM policy if the compile time option
> ACM_SECURITY was not set. Thoughts?

I think I'd prefer adding this to xen/acm/Makefile:
        obj-$(CONFIG_POWERPC) += acm_powerpc.o
        obj-$(CONFIG_IA64) += acm_ia64.o

Hollis Blanchard
IBM Linux Technology Center

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>