WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] [PATCH] "lock cmpxch8b" and split locks

To: "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH] "lock cmpxch8b" and split locks
From: "Puthiyaparambil, Aravindh" <aravindh.puthiyaparambil@xxxxxxxxxx>
Date: Thu, 6 Oct 2005 00:53:27 -0400
Cc: "Koren, Bradley J" <Bradley.Koren@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx, "Vessey, Bruce A" <Bruce.Vessey@xxxxxxxxxx>, "Subrahmanian, Raj" <raj.subrahmanian@xxxxxxxxxx>
Delivery-date: Thu, 06 Oct 2005 04:51:02 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcXJ/tCdUWI0+QpCRXajDXoD7Q+yjAAAEySAAAybjpA=
Thread-topic: [Xen-devel] [PATCH] "lock cmpxch8b" and split locks
Keir,

Sorry about breaking x86_32. 

The fixed up patch takes care of the misalignment.

Thanks,
Aravindh
PS: Please ignore my message below.

> -----Original Message-----
> From: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx [mailto:xen-devel-
> bounces@xxxxxxxxxxxxxxxxxxx] On Behalf Of Puthiyaparambil, Aravindh
> Sent: Wednesday, October 05, 2005 6:51 PM
> To: Keir Fraser
> Cc: Koren, Bradley J; xen-devel@xxxxxxxxxxxxxxxxxxx; Vessey, Bruce A;
> Subrahmanian, Raj
> Subject: RE: [Xen-devel] [PATCH] "lock cmpxch8b" and split locks
> 
> I just realized that moving 'tlbflush_timestamp' to the end of the
> structure will make us trip up on cmpxchg(&page->u.inuse.type_info, x,
> nx) in put_page_type().
> 
> I think we have to come up with an alternative solution.
> 
> Aravindh
> 
> > -----Original Message-----
> > From: Keir Fraser [mailto:Keir.Fraser@xxxxxxxxxxxx]
> > Sent: Wednesday, October 05, 2005 6:40 PM
> > To: Puthiyaparambil, Aravindh
> > Cc: Vessey, Bruce A; xen-devel@xxxxxxxxxxxxxxxxxxx; Koren, Bradley
J;
> > Subrahmanian, Raj
> > Subject: Re: [Xen-devel] [PATCH] "lock cmpxch8b" and split locks
> >
> >
> > On 5 Oct 2005, at 23:16, Puthiyaparambil, Aravindh wrote:
> >
> > > Which looks something like my attachment? :-)
> > >
> > > Signed off by: Aravindh Puthiyaparambil
> > > <aravindh.puthiyaparambil@xxxxxxxxxx>
> >
> > Turns out it breaks x86/64. I checked in a fixed up version.
> >
> >   -- Keir
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel