This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] fix broken ACM

To: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] fix broken ACM
From: aq <aquynh@xxxxxxxxx>
Date: Fri, 24 Jun 2005 00:22:04 +0900
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Stefan Berger <stefanb@xxxxxxxxxx>
Delivery-date: Thu, 23 Jun 2005 15:21:00 +0000
Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=sHYN1HJiLPa/iy1cWo31VHGmCbJgPMcA849dj5m3CnBQzk5N+uI3pONBa3Oq8pcgkh5VY6GYrRUZovYdthOxXOshFj/MX/SgPdH5KZINeXnZyk9zX4j6O6jiGuraorHt1pokVFzIad3w+6XrXbqhM+XN/4PhehkacnVD5aNa9kU=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <7ae02d710529059790220f4430ef0fae@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <OF25D3AF68.4EFCC56D-ON85257029.0051A82F-85257029.005227EC@xxxxxxxxxx> <7ae02d710529059790220f4430ef0fae@xxxxxxxxxxxx>
Reply-to: aq <aquynh@xxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On 6/24/05, Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> wrote:
> On 23 Jun 2005, at 15:57, Stefan Berger wrote:
> >> ok, i see the point. the problem is because i moved some codes
> >> (acm_init() and acm_init_binary_policy()) to acm_hooks.h. now it seems
> >> better to move them back. but it is weird that i got no problem with
> >> gcc 3.3.5
> >>
> >> could you please try again with the new patch below?
> >
> > I tried it with your attached patch. There was an unused function when
> > trying out the NULL policy. The attached patch on top of yours and
> > things
> > compile fine.
> I'm still confused what these patches are aiming to fix. If we are
> building 'NULL' security policy then all the hooks should compile away
> to nothing and acm core files do not get built. So why do they need
> patching with ifdef's conditional on whether or not the policy is
> 'NULL'?
> Currently, if you re-enable building of acm/ directory in the Xen root
> Makefile, yet the ACM_USE_SECURITY_POLICY is NULL_POLICY, the build
> will certainly fail. But I don;t see why we would want to support that.
> :-)

Keir, certainly i understand your point. but this patch doesnt harm, anyway ;-)

one annoying problem at the moment is that if we want to compile ACM
in, we should modify the value of ACM_USE_SECURITY_POLICY, since the
current default value is ACM_NULL_POLICY( which is meaningless as Keir
pointed out )

any clean way to overcome this problem?


Xen-devel mailing list