Re: [Xen-devel] [PATCH] fix broken ACM

[aq <aquynh@xxxxxxxxx>]

On 6/24/05, Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> wrote:
> 
> On 23 Jun 2005, at 16:22, aq wrote:
> 
> > Keir, certainly i understand your point. but this patch doesnt harm,
> > anyway ;-)
> 
> We need to understand why a patch is useful before we apply it.
> 
> > one annoying problem at the moment is that if we want to compile ACM
> > in, we should modify the value of ACM_USE_SECURITY_POLICY, since the
> > current default value is ACM_NULL_POLICY( which is meaningless as Keir
> > pointed out )
> >
> > any clean way to overcome this problem?
> 
> The way I skip building acm directory in the root Makefile is quite
> gross, and won't actually detect if you edit ACM_USE_SECURITY_POLICY.
> Probably need to think about ways of cleanly expressing a new build
> config option for security policies etc. Then Makefile decision can
> hook off of that.

There is one solution: define the value of ACM_USE_SECURITY_POLICY in
xen/Makefile, then "make" will put its value into acm code (using sed
on a "template" configuration header file, for example)

Is that clean enough? If that is fine, I am ready to send a patch.

regards,
aq

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel