This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] fix broken ACM

To: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] fix broken ACM
From: aq <aquynh@xxxxxxxxx>
Date: Fri, 24 Jun 2005 07:06:10 +0900
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Stefan Berger <stefanb@xxxxxxxxxx>
Delivery-date: Thu, 23 Jun 2005 22:05:07 +0000
Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=UjdDnCIrOKBcM0oqsBkxOl6mjy2k5i2zB4MQHr/K05wHx2e2N8krCPUxgHEh5ibDSj975OQkyeA2/hShCvXIKouuN/dOuBNiwdLwUwbJLeBX1Ws+BgHygQVVCvvI0dG+JkAz5UZcbYG2Y++ott0ddZ+SdNkBTVqMEBSB1NDbVkg=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <6b08ec7c5c15235c3fb974971b1638ac@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <OF25D3AF68.4EFCC56D-ON85257029.0051A82F-85257029.005227EC@xxxxxxxxxx> <7ae02d710529059790220f4430ef0fae@xxxxxxxxxxxx> <9cde8bff05062308227dfd471e@xxxxxxxxxxxxxx> <6b08ec7c5c15235c3fb974971b1638ac@xxxxxxxxxxxx>
Reply-to: aq <aquynh@xxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On 6/24/05, Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> wrote:
> On 23 Jun 2005, at 16:22, aq wrote:
> > Keir, certainly i understand your point. but this patch doesnt harm,
> > anyway ;-)
> We need to understand why a patch is useful before we apply it.
> > one annoying problem at the moment is that if we want to compile ACM
> > in, we should modify the value of ACM_USE_SECURITY_POLICY, since the
> > current default value is ACM_NULL_POLICY( which is meaningless as Keir
> > pointed out )
> >
> > any clean way to overcome this problem?
> The way I skip building acm directory in the root Makefile is quite
> gross, and won't actually detect if you edit ACM_USE_SECURITY_POLICY.
> Probably need to think about ways of cleanly expressing a new build
> config option for security policies etc. Then Makefile decision can
> hook off of that.

There is one solution: define the value of ACM_USE_SECURITY_POLICY in
xen/Makefile, then "make" will put its value into acm code (using sed
on a "template" configuration header file, for example)

Is that clean enough? If that is fine, I am ready to send a patch.


Xen-devel mailing list