WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH] fix broken ACM

To: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH] fix broken ACM
From: aq <aquynh@xxxxxxxxx>
Date: Thu, 23 Jun 2005 17:19:58 +0900
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Thu, 23 Jun 2005 08:18:56 +0000
Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=hW0jqoyii/AfUfect2XSq+cF2m6u9x8E0K2bvH3qo0OihoYQtmRG+so54lMDhy9De1voW0IJsoA1jUrG/uh/ICwvSn27ghadSbVXC5y7kd8XGMHCjRIYvhHpjHy2gJp6rv+cYAKCWtmi6Q31tAXVdSXtam5aKSzmcQLe8AXNRW0=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <fcae06f78d0ae10d819b69c26a661955@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <9cde8bff05062210406b403295@xxxxxxxxxxxxxx> <d34221930728cff10e5f14189686a95b@xxxxxxxxxxxx> <9cde8bff05062210523e7dd070@xxxxxxxxxxxxxx> <d76838683599c2d711a55d42c82f3a23@xxxxxxxxxxxx> <9cde8bff050623010440448361@xxxxxxxxxxxxxx> <fcae06f78d0ae10d819b69c26a661955@xxxxxxxxxxxx>
Reply-to: aq <aquynh@xxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On 6/23/05, Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> wrote:
> 
> On 23 Jun 2005, at 09:04, aq wrote:
> 
> > i see, but the problem occurs if we want to compile it. the reason is
> > because you grouped null ops together, but you accidentally hide some
> > structures and variables. also we must enclose the declare of
> > acm_init() in #if (ACM_USE_SECURITY_POLICY = ACM_NULL_POLICY).  please
> > see my second patch.
> 
> If we build non-NULL security policy then the struct definitions and so
> on are compiled in, because they are in the else clause of the acm
> header file.

yes, that is true. but the default policy is NULL, and we get the
problem compiling the code at the moment. my patch does nothing, just
tries to fix the compiling problem (in default state).

regards,
aq

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel