[Xen-devel] Re: [PATCH] fix broken ACM

To:	Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Subject:	[Xen-devel] Re: [PATCH] fix broken ACM
From:	aq <aquynh@xxxxxxxxx>
Date:	Thu, 23 Jun 2005 17:04:22 +0900
Cc:	xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date:	Thu, 23 Jun 2005 08:03:26 +0000
Domainkey-signature:	a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=O4XFnB1XLDzdNUkCs5buWyO/tWnn/z/Dd5htOT3wSqqDEkk4Sa9fp/mjBArhRA5kHn8H4ndwps3SBHqlpx1LiIWhkTGFP/ypbP4LJbjf7+lLZkyQcO6mtv4mdX2If1OKkFIVLS21iKOGnoolkx6QDeIe+2+LnWpuwOJzQLRY7t0=
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<d76838683599c2d711a55d42c82f3a23@xxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References:	<9cde8bff05062210406b403295@xxxxxxxxxxxxxx> <d34221930728cff10e5f14189686a95b@xxxxxxxxxxxx> <9cde8bff05062210523e7dd070@xxxxxxxxxxxxxx> <d76838683599c2d711a55d42c82f3a23@xxxxxxxxxxxx>
Reply-to:	aq <aquynh@xxxxxxxxx>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

On 6/23/05, Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> wrote:
> 
> On 22 Jun 2005, at 18:52, aq wrote:
> 
> > are you sure? on my system, without the patch acm_init() would be
> > defined twice.
> >
> > also, some structrures and global variables  are hidden in the #else
> > (of #if (ACM_USE_SECURITY_POLICY == ACM_NULL_POLICY) )
> >
> >
> > how did you compile acm?
> 
> The whole point is not to bother, if the statically chosen security
> policy is null. 

i see, but the problem occurs if we want to compile it. the reason is
because you grouped null ops together, but you accidentally hide some
structures and variables. also we must enclose the declare of
acm_init() in #if (ACM_USE_SECURITY_POLICY = ACM_NULL_POLICY).  please
see my second patch.

regards,
aq

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

[Xen-devel] Re: [PATCH] fix broken ACM