[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 1/1] xen/arm: gic-v3: Fix wake-up loop in gicv3_enable_redist
- To: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Luca Fancellu <luca.fancellu@xxxxxxx>
- From: Mykola Kvach <xakep.amatop@xxxxxxxxx>
- Date: Tue, 19 May 2026 08:01:27 +0300
- Arc-authentication-results: i=1; mx.google.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=hTy/+IFaQjdkHID9o6qdzYbGMtuAqjMfzGV2qdYxS+g=; fh=uWsTkjyBGGFEWoM6xZO7XjUPbTD7WoYscIlYAYCsDeI=; b=dTcntxtGrwUWIsp0VxVYIOWVEQcv5aDVGNJREZtFQIvdiqSu7pijiNeuRk0Aw8g3pJ TO7BHu70cbVOMHhw717Ozt/6u/LS/YGuw0PMwqdc+AzxeHcgjpHLoQAw/p2MucmmkHQe lX7LzCxqnO56EwYRIzEtBqLSWXcPhgk3KQExNjcPeEZGqOtdMxHSNxwK7TBhwRZYYcsX m7WD6xol6sbQwH+kZisawHtpQAAaqx+wG6aWtqvP+6V5pfRdLSDFnjMm7mZdk3dqo5LH fXOZVN6z0iP8O25J0sFy81XqNxOKsL0pArm/nhSvAsGAacTdNXdpRwIGSO8RhV9YiEI8 gueA==; darn=lists.xenproject.org
- Arc-seal: i=1; a=rsa-sha256; t=1779166899; cv=none; d=google.com; s=arc-20240605; b=IADRQcWBrBcEFTgcF+z5BddVeQ2wQSmdps/CzVG42gQY8sB6Pk7vq7ibAy0daRPbue juQscHlV8raWo2XAN2UuiMUTrylCKHDp9aGx9nCHF4QjP3YTxvISFBnKa4+ZTVA1DTKu uLTEf2t8L5mBpS5Ex/Yl+l39KJI+qrdEWo9pxPxKcgkPirQCFUZakR31IhzDVFf+GAzk YvI/mqFC8lmml5tzLnrG8TAR1/K+A1yr1X/xY2uW1DaDF7KRqO+vLRYn+dlGiLWNKKpW dWyT/dCpbv19F4eNk3VyfifKNRboIrMeFKfU7tDQzpg4kCn4dStD4GdMHSvSGs3fw1LG W2Ug==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References:MIME-Version"
- Cc: "Edgar E. Iglesias" <edgar.iglesias@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, julien@xxxxxxx, bertrand.marquis@xxxxxxx, michal.orzel@xxxxxxx, Volodymyr_Babchuk@xxxxxxxx, edgar.iglesias@xxxxxxx, oleksii.kurochko@xxxxxxxxx
- Delivery-date: Tue, 19 May 2026 05:01:59 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi all,
I think this issue is already covered by Luca's patch, currently under
review:
xen/arm: gic-v3: Fix redistributor wakeup polling
Best regards,
Mykola
On Tue, May 19, 2026 at 3:47 AM Stefano Stabellini
<sstabellini@xxxxxxxxxx> wrote:
>
> On Tue, 19 May 2026, Edgar E. Iglesias wrote:
> > From: "Edgar E. Iglesias" <edgar.iglesias@xxxxxxx>
> >
> > timeout starts as false and is only set on the timeout break, so the
> > loop always exits after one iteration and a stuck redistributor is
> > silently treated as woken. Use while ( 1 ) to match the sibling
> > gicv3_do_wait_for_rwp().
> >
> > Fixes: bc183a0235 ("xen/arm: Add support for GIC v3")
> > Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xxxxxxx>
>
> Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
>
>
> > ---
> > xen/arch/arm/gic-v3.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c
> > index 7f365cdbe9..f03217282e 100644
> > --- a/xen/arch/arm/gic-v3.c
> > +++ b/xen/arch/arm/gic-v3.c
> > @@ -828,7 +828,7 @@ static int gicv3_enable_redist(void)
> > }
> > cpu_relax();
> > udelay(1);
> > - } while ( timeout );
> > + } while ( 1 );
> >
> > if ( timeout )
> > {
> > --
> > 2.43.0
> >
>
|
