[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH v1 1/1] xen/arm: gic-v3: Fix wake-up loop in gicv3_enable_redist



From: "Edgar E. Iglesias" <edgar.iglesias@xxxxxxx>

timeout starts as false and is only set on the timeout break, so the
loop always exits after one iteration and a stuck redistributor is
silently treated as woken. Use while ( 1 ) to match the sibling
gicv3_do_wait_for_rwp().

Fixes: bc183a0235 ("xen/arm: Add support for GIC v3")
Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xxxxxxx>
---
 xen/arch/arm/gic-v3.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c
index 7f365cdbe9..f03217282e 100644
--- a/xen/arch/arm/gic-v3.c
+++ b/xen/arch/arm/gic-v3.c
@@ -828,7 +828,7 @@ static int gicv3_enable_redist(void)
         }
         cpu_relax();
         udelay(1);
-    } while ( timeout );
+    } while ( 1 );
 
     if ( timeout )
     {
-- 
2.43.0




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.