Re: [PATCH v1 1/1] xen/arm: gic-v3: Fix wake-up loop in gicv3_enable_redist

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Tue, 19 May 2026, Edgar E. Iglesias wrote:
> From: "Edgar E. Iglesias" <edgar.iglesias@xxxxxxx>
> 
> timeout starts as false and is only set on the timeout break, so the
> loop always exits after one iteration and a stuck redistributor is
> silently treated as woken. Use while ( 1 ) to match the sibling
> gicv3_do_wait_for_rwp().
> 
> Fixes: bc183a0235 ("xen/arm: Add support for GIC v3")
> Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xxxxxxx>

Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>


> ---
>  xen/arch/arm/gic-v3.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c
> index 7f365cdbe9..f03217282e 100644
> --- a/xen/arch/arm/gic-v3.c
> +++ b/xen/arch/arm/gic-v3.c
> @@ -828,7 +828,7 @@ static int gicv3_enable_redist(void)
>          }
>          cpu_relax();
>          udelay(1);
> -    } while ( timeout );
> +    } while ( 1 );
>  
>      if ( timeout )
>      {
> -- 
> 2.43.0
>