WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ia64-devel

Re: [Xen-ia64-devel] [patch] increase xen-heap-size based on nodes-shift

To: Isaku Yamahata <yamahata@xxxxxxxxxxxxx>
Subject: Re: [Xen-ia64-devel] [patch] increase xen-heap-size based on nodes-shift
From: Jes Sorensen <jes@xxxxxxx>
Date: Thu, 14 Jun 2007 10:43:30 +0200
Cc: Alex Williamson <alex.williamson@xxxxxx>, xen-ia64-devel <xen-ia64-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Thu, 14 Jun 2007 01:41:21 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20070614083932.GD18943%yamahata@xxxxxxxxxxxxx>
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
References: <466FF49D.3000400@xxxxxxx> <20070613150351.GA26843%yamahata@xxxxxxxxxxxxx> <4670096F.6020008@xxxxxxx> <20070613152646.GB26843%yamahata@xxxxxxxxxxxxx> <4670F1FD.3000105@xxxxxxx> <20070614083932.GD18943%yamahata@xxxxxxxxxxxxx>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird 1.5.0.4 (X11/20060527)
Isaku Yamahata wrote:
> On Thu, Jun 14, 2007 at 09:45:01AM +0200, Jes Sorensen wrote:
> I agree that it is safe bet to increase the default value.
> What I wanted to say is
>   I don't insist on the dafault value and I just hoped you to add
>   xenheap_megabytes support.
> However you seem to dislike modifying/updating your patch.
> It's okay. If you don't, someone else (probably me) will do.

Hello Isaku,

I don't modifying my patch, but I think adding xenheap_megabytes_support
as a boot time option is a different patch from mine. I think we agree
on this?

For the paranthesis, then I don't mind redoing the patch with those in
it, it's not a big deal for me.

Does thos work better?

Cheers,
Jes

# HG changeset patch
# User jes@xxxxxxxxxxxxxxxx
# Date 1181742127 -7200
# Node ID 21714d18a7583866b23ba4f5e1f8f95f51b460c8
# Parent  96617c4f19aaefa5ae5f1ceef6b5734f3c76c2ce
For bigger system the default size of XENHEAP is far from
sufficient. This bases the size of XENHEAP on the NODES_SHIFT, leaving
the old default for a NODES_SHIFT <= 5 for those who prefer to compile
a smaller Xen.

Signed-off-by: Jes Sorensen <jes@xxxxxxx>

diff -r 96617c4f19aa -r 21714d18a758 xen/include/asm-ia64/config.h
--- a/xen/include/asm-ia64/config.h     Tue Jun 12 20:41:08 2007 -0600
+++ b/xen/include/asm-ia64/config.h     Wed Jun 13 15:42:07 2007 +0200
@@ -111,8 +111,12 @@ extern char _end[]; /* standard ELF symb
 ///////////////////////////////////////////////////////////////
 // xen/include/asm/config.h
 // Natural boundary upon TR size to define xenheap space
-#define XENHEAP_DEFAULT_MB (1 << (KERNEL_TR_PAGE_SHIFT - 20))
+#if (NODES_SHIFT > 5)
+#define XENHEAP_DEFAULT_SIZE   (1 << (KERNEL_TR_PAGE_SHIFT + NODES_SHIFT - 6))
+#else
 #define XENHEAP_DEFAULT_SIZE   (1 << KERNEL_TR_PAGE_SHIFT)
+#endif
+#define XENHEAP_DEFAULT_MB     (XENHEAP_DEFAULT_SIZE >> 20)
 #define        ELFSIZE 64
 
 ///////////////////////////////////////////////////////////////
_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel