Re: [Xen-ia64-devel] [patch] increase xen-heap-size based on nodes-shift

[Isaku Yamahata <yamahata@xxxxxxxxxxxxx>]

On Wed, Jun 13, 2007 at 05:12:47PM +0200, Jes Sorensen wrote:
> Isaku Yamahata wrote:
> > On Wed, Jun 13, 2007 at 03:43:57PM +0200, Jes Sorensen wrote:
> 
> >> For the bigger systems we need a slightly bigger heap or the heap
> >> will overflow. Unfortunately there is no easy way to determine the
> >> size dynamically this early in the boot process before the nodes have
> >> been discovered.
> > 
> > Should we introduce xenheap_megabytes boot parameter
> > like x86, powerpc instead of changing default value?
> 
> We could do that, but I think we should do it on top of my patch. Ie.
> I think it's better to have a too large heap per default and then let
> the users reduce it rather than the other way round. What do you think?

The default value won't matter so much as long as xenheap_megabytes option
is introduced, I think.


>+#define XENHEAP_DEFAULT_MB     XENHEAP_DEFAULT_SIZE >> 20

It would be better to use parens.
-- 
yamahata

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel